Update the interfaces about folly::future and fbthrift constructor #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangleptr
requested review from
monadbobo,
dutor,
darionyaphet,
CPWstatic,
critical27,
laura-ding and
liuyu85cn
darionyaphet
reviewed
Oct 29, 2019
src/kvstore/raftex/RaftPart.cpp
Outdated
| @@ -775,7 +775,7 @@ void RaftPart::replicateLogs(folly::EventBase* eb, | |||
| return resp.get_error_code() == cpp2::ErrorCode::SUCCEEDED | |||
| && !hosts[index]->isLearner(); | |||
| }) | |||
| .then(executor_.get(), [self = shared_from_this(), | |||
| .via(executor_.get()).then([self = shared_from_this(), | |||
There was a problem hiding this comment.
Should using thenValue to replace then ?
There was a problem hiding this comment.
Because we need to handle the exception in folly::Try, so we should use "then" in this place.
|
Unit testing failed. |
|
Unit testing passed. |
|
src/meta/test/TestUtils.h +131 maybe some others in |
|
Unit testing failed. |
|
Jenkins go |
liuyu85cn
approved these changes
Nov 7, 2019
|
Unit testing failed. |
|
Unit testing passed. |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some interfaces have been changed in the latest version of folly and fbthrift.
Let's modify them to avoid broken under latest dependencies.
Subtask of #1160