-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the interfaces about folly::future and fbthrift constructor #1161
Conversation
src/kvstore/raftex/RaftPart.cpp
Outdated
@@ -775,7 +775,7 @@ void RaftPart::replicateLogs(folly::EventBase* eb, | |||
return resp.get_error_code() == cpp2::ErrorCode::SUCCEEDED | |||
&& !hosts[index]->isLearner(); | |||
}) | |||
.then(executor_.get(), [self = shared_from_this(), | |||
.via(executor_.get()).then([self = shared_from_this(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should using thenValue
to replace then
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we need to handle the exception in folly::Try, so we should use "then" in this place.
Unit testing failed. |
Unit testing passed. |
src/meta/test/TestUtils.h +131 maybe some others in |
Unit testing failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jenkins go |
Unit testing failed. |
Unit testing passed. |
* send/recv file by proxygen * send snapshot by sending files * unlock when SnapshotTask::operator() done * wait for promise set value if casStop failed in sendFiles() * release snapshot before host stop * capture shared ptr in sendheartbeat lambda * wait for host stop when removing peers in checkpeers * fix heap use after free * fix memory leak in snapshot * fix comments Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Some interfaces have been changed in the latest version of folly and fbthrift.
Let's modify them to avoid broken under latest dependencies.
Subtask of #1160