Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VEUE-32 adds svgs and styling of vidoes#show page #34

Merged
merged 6 commits into from
Sep 16, 2020
Merged

VEUE-32 adds svgs and styling of vidoes#show page #34

merged 6 commits into from
Sep 16, 2020

Conversation

Sirbuland
Copy link
Collaborator

@Sirbuland Sirbuland commented Sep 16, 2020 •
edited
Loading

This PR provides following functionality:

  1. SVG handling using inline_svg gem.
  2. Include svgs as icons in place of images.
  3. Created a custom type for including svg files in typescript using import e.g: import userSVG from '../images/user.svg'.
  4. Overall revamp of video page styling.
  5. Added products section.
  6. Added player buttons.

HamptonMakes
HamptonMakes requested changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@HamptonMakes HamptonMakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweaks!

app/views/shared/_message.html.haml Outdated Show resolved Hide resolved
app/views/videos/partials/_products_area.html.haml Show resolved Hide resolved
app/views/videos/show.html.haml Outdated Show resolved Hide resolved
app/javascript/style/components/_product_card.scss Outdated Show resolved Hide resolved
@Sirbuland Sirbuland changed the title adds svgs and styling of vidoes#show page VEUE-32 adds svgs and styling of vidoes#show page Sep 16, 2020
@HamptonMakes
Copy link
Contributor

Task linked: VEUE-32 Vectorize All The Things!

@Sirbuland Sirbuland force-pushed the feature/style_video_page branch 2 times, most recently from ea2d350 to 716b8be Compare September 16, 2020 17:13
HamptonMakes
HamptonMakes approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@HamptonMakes HamptonMakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Good work @Sirbuland !

@HamptonMakes HamptonMakes merged commit 3c45fc8 into main Sep 16, 2020
@HamptonMakes HamptonMakes deleted the feature/style_video_page branch September 16, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamptonMakes HamptonMakes HamptonMakes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sirbuland @HamptonMakes