Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Better lyrics #13

Closed
noClaps opened this issue Jun 7, 2022 · 4 comments
Closed

Better lyrics #13

noClaps opened this issue Jun 7, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@noClaps
Copy link

noClaps commented Jun 7, 2022

Feature description

You should fetch lyrics from a better, more accurate source such as Genius or Musixmatch. Either do this by default or provide an option to enable this for those who want it.

Why do you want this feature?

The lyrics currently in the app are fetched from YT Music, but they're often inaccurate or simply not available for many songs. By comparison, Genius as a huge database of lyrics, and they're often much more accurate.

Additional information

No response

@noClaps noClaps added the enhancement New feature or request label Jun 7, 2022
@vfsfitvnm
Copy link
Owner

Genius and Musixmatch do not have a public api so I definitely won't interact with them.

(copied from #1)

I think I could just add a "search lyrics online" text button which opens the browser with a input like "artist song lyrics" or similar. So you could fetch the lyrics from whatever service you prefer.

Then, I could store the lyrics in the database, so the user can edit them (if they are wrong or missing).

I think this is a good compromise.

@vfsfitvnm
Copy link
Owner

vfsfitvnm commented Jun 15, 2022

I think I could just add a "search lyrics online" text button which opens the browser with a input like "artist song lyrics" or similar. So you could fetch the lyrics from whatever service you prefer.

Then, I could store the lyrics in the database, so the user can edit them (if they are wrong or missing).

Implemented in v0.1.5.

@noClaps
Copy link
Author

noClaps commented Jun 16, 2022

Which database are you referring to? If I make changes to lyrics will they be available to all other users, or are they locally stored in the app? If the former, where are you storing the edits/lyrics, and is there a moderation process to protect against trolls?

@vfsfitvnm
Copy link
Owner

It's your local (private) database

ShareASmile pushed a commit to ShareASmile/ViMusic that referenced this issue Jul 27, 2023
…I_response_parsing

fix search api response parsing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants