Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work as an external project or add_subdirectory directory #74

Merged
merged 5 commits into from
Aug 11, 2020

Conversation

adamnovak
Copy link
Member

This has the changes to the CMake build system I needed to make this project a well-behaved external project or subdirectory.

@adamnovak
Copy link
Member Author

adamnovak commented Aug 11, 2020

This should be enough to pass tests on Mac and Linux and to work as an add_subdirectory() in vgteam/libbdsg_example on Linux when installing the depending project.

I think to work on Mac with libbdsg_example when installing the depending project, we need to change the external_project() calls in this repo that result in dylibs into add_subdirectory() calls, so the actual final install step can be in charge of setting all the install names. But I think that will be another PR.

@adamnovak adamnovak merged commit f30403a into master Aug 11, 2020
@adamnovak
Copy link
Member Author

This should work as an external project too but whatever uses it that way would have the same install name problem on Mac that we have with our own dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant