Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bdsg Python module installable via Pip on Mac #85

Merged
merged 4 commits into from
Oct 2, 2020
Merged

Conversation

adamnovak
Copy link
Member

@adamnovak adamnovak commented Oct 2, 2020

This makes the bdsg module that pip install --upgrade bdsg will produce actually work.

At the end of the CMake build, setup,py now just goes in and rewrites all the references between libraries to use @loader_path and thus be relative to the file asking for the load. That's how Numpy's pre-built Mac wheels get their libraries to find each other.

I'm also (in the Mac wheels only, for now), eliminating all the versioned symlinks and just pointing everything to the actual files, because in a wheel those symlinks become duplicate copies of the libraries, because (I think) zip files can't do symlinks. This will make the installed size smaller.

I also make an attempt to build with the right number of threads for your machine now, using code I wrote for Toil.

This fixes #83.

@adamnovak adamnovak merged commit 149ab44 into master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant