-
Notifications
You must be signed in to change notification settings - Fork 47
DOCS-1105: Add mlmodel extra for PySDK #2122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-1105: Add mlmodel extra for PySDK #2122
Conversation
Overall readability score: 56.2 (🟢 +0.01)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few comments on how the instructions might be redundant, but they will work!
docs/services/ml/_index.md
Outdated
pip install viam-sdk | ||
pip install 'viam-sdk[mlmodel]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
installing viam-sdk[mlmodel]
includes the base viam-sdk
itself, so you don't need both commands here
docs/tutorials/projects/guardian.md
Outdated
pip3 install viam-sdk python-vlc | ||
pip3 install 'viam-sdk[mlmodel]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, viam-sdk[mlmodel]
includes the base SDK
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/2122/public |
Add notice that Python SDK users must now also install the
mlmodel
extra alongside the Python SDK in order to use the ML Model service.input_data
oroutput_data
nomenclature). Guess: no changes needed to these tutorials, besides additional dep install step now documentation.