Skip to content

Move vale vocab main to dir that vale >=3.0.0 expects #4385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025

Conversation

adit-chandra
Copy link
Contributor

Per https://vale.sh/docs/keys/vocab:

In versions of Vale prior to 3.0, vocabularies were stored in /Vocab. When upgrading from an older version of Vale, you'll need to move your vocabularies to the new /config/vocabularies location.

Tested: successfully ran Vale 3.11.2 (latest) locally using the Viam vale.ini located in this repo.

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ npentrel
❌ adit-chandra
You have signed the CLA already but the status is still pending? Let us recheck it.

@viambot
Copy link
Member

viambot commented Jun 6, 2025

👋 Thanks for contributing! A reviewer will look at it on the next working day!

Copy link

netlify bot commented Jun 6, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 535ed88
🔍 Latest deploy log https://app.netlify.com/projects/viam-docs/deploys/68489d0abda7fd00082672c6
😎 Deploy Preview https://deploy-preview-4385--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 50 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@npentrel npentrel changed the title move vale vocab main to dir that vale >=3.0.0 expects Move vale vocab main to dir that vale >=3.0.0 expects Jun 10, 2025
@npentrel npentrel merged commit e108ff4 into viamrobotics:main Jun 10, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants