RSDK-11273: Modify Python motion wrappers to send strings #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
benjirewis
reviewed
Sep 19, 2025
There was a problem hiding this comment.
I realize still in draft, but LGTM. Similar to other SDK PRs, let's hold off on merging until the viamrobotics/rdk#5282 are merged (and it's not a Friday).
benjirewis
approved these changes
Sep 19, 2025
njooma
pushed a commit
that referenced
this pull request
Sep 22, 2025
[njooma] Overriding because we have a PR waiting that fixes all these issues (#1003)
stuqdog
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows sending resource names as short strings instead of ResourceName in Python SDK