Skip to content

Conversation

cheukt
Copy link
Member

@cheukt cheukt commented Apr 24, 2023

a piece of feedback I got was that some of the inherited methods would be useful to see in the docs - however, doing it blindly will show documentation for far too much stuff, especially in the generated code

basically adds this section into every resource definition file
Screen Shot 2023-04-24 at 13 39 56

also fixed a typo in show-inheritance

@cheukt cheukt requested a review from a team as a code owner April 24, 2023 17:43
docs/conf.py Outdated
copyright = u"2022, Viam Inc"
author = u"Viam Inc"
project = "Viam Python SDK"
copyright = "2023, Viam Inc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the full range of years?

Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cheukt cheukt merged commit b269e2b into viamrobotics:main Apr 24, 2023
@cheukt cheukt deleted the add-some-inherited-fields branch April 24, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants