RSDK-2844 - localhost connections fail in certain internet configurations #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the previous SSL fix (RSDK-2203 - Update server hostname if address and auth_entity don't match by cheukt · Pull Request #242 · viamrobotics/viam-python-sdk ) introduced a subtle bug where we now look for a connection to the auth_entity instead of localhost during the connection phase. I found this by monkeypatching socket.getaddrinfo and seeing that the args have changed.
I found this issue while at a friend's apartment - not sure why this only doesn’t work in certain network configurations (the original code worked in the office and still works in my hotspot). Fix seems to be to pass
server_hostnamealong as a different parameter