Skip to content

Conversation

purplenicole730
Copy link
Member

@purplenicole730 purplenicole730 commented Apr 26, 2023

From now on, service classes in server.py files are ResourceRPCService, including in components. Service clients now don't have the word Service between the Resource and Client.

This is to help prepare as we move towards supporting services.

@purplenicole730 purplenicole730 marked this pull request as ready for review April 28, 2023 18:10
@purplenicole730 purplenicole730 requested a review from a team as a code owner April 28, 2023 18:10
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo one question!

@purplenicole730 purplenicole730 requested a review from cheukt May 1, 2023 18:38
Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits, but generally looks great!

@purplenicole730 purplenicole730 requested a review from cheukt May 1, 2023 20:38
@purplenicole730 purplenicole730 requested a review from cheukt May 1, 2023 21:46
@purplenicole730 purplenicole730 merged commit f3fbb9f into viamrobotics:main May 2, 2023
@purplenicole730 purplenicole730 deleted the RSDK-1831-slam-wrapper branch May 2, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants