RSDK-1623 - decode custom depth mime type #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

purplenicole730 merged 11 commits into viamrobotics:main from purplenicole730:RSDK-1623-decode-custom-depth-mime-type

May 12, 2023

Member

purplenicole730 commented May 5, 2023 •

edited

Loading

GetImage might return a custom MIME type, but for a user to use the data, they need to turn the data into a standard representation.

Changes:

Add a helper function that converts the data of a custom MIME type to an array of integers
Add a test to make sure that an artifact image converts correctly
Add documentation
Add a new folder named data/ where we store a fake image

purplenicole730 added 2 commits

May 4, 2023 16:44


          add bytes_to_depth_array function

8fc4b0d


          add tests

a63c1db

purplenicole730 commented

View reviewed changes

tests/mocks/fakeDM.vnd.viam.dep Show resolved Hide resolved

purplenicole730 commented

View reviewed changes

tests/test_camera.py Outdated Show resolved Hide resolved

purplenicole730 commented

View reviewed changes

src/viam/media/video.py Outdated Show resolved Hide resolved


          Add documentation

f29be26

purplenicole730 commented

View reviewed changes

tests/test_camera.py Outdated Show resolved Hide resolved

purplenicole730 commented

View reviewed changes

src/viam/media/video.py Outdated Show resolved Hide resolved

Member

cheukt commented May 5, 2023

nit: PR name should be RSDK-1623 - XXX - useful for linking back to JIRA

purplenicole730 changed the title ~~Rsdk 1623 decode custom depth mime type~~ Rsdk-1623-decode custom depth mime type

purplenicole730 added 4 commits

May 9, 2023 10:03


          make comment clearer

847fdef


          clean test

b878bb2


          Clean up function comment

c7d9f7d


          move fake image into a data folder

5c556e2

purplenicole730 marked this pull request as ready for review

May 9, 2023 16:33

purplenicole730 requested a review from a team as a code owner

May 9, 2023 16:33

purplenicole730 requested review from clintpurser and zaporter-work

May 9, 2023 16:33

zaporter-work approved these changes

View reviewed changes

zaporter-work left a comment

lgtm

src/viam/media/video.py

    
                      width = int.from_bytes(self.data[8:16], "big")

                      height = int.from_bytes(self.data[16:24], "big")

                      depth_arr = array("H", self.data[24:])

zaporter-work May 9, 2023 •

edited

Loading

I am surprised you dont specify the endianness of these unsigned shorts but you do for the other values.

njooma reviewed

View reviewed changes

src/viam/components/camera/camera.py Outdated Show resolved Hide resolved


          Update src/viam/components/camera/camera.py

8e6680a

Co-authored-by: Naveed Jooma <naveed@joo.ma>

purplenicole730 changed the title ~~Rsdk-1623-decode custom depth mime type~~ RSDK-1623 - decode custom depth mime type


          move test to new test_media.py

7634f9a

purplenicole730 requested a review from bhaney

May 9, 2023 19:03


          return a list of lists

8cdfaf8

bhaney requested changes

View reviewed changes

Member

bhaney left a comment

looking good, could you just add some explicit checks to the tests as well

tests/test_media.py Outdated Show resolved Hide resolved

tests/test_media.py Outdated Show resolved Hide resolved

Member

clintpurser commented May 10, 2023

Looks like you are covered here, I will un assign myself so there aren't too many cooks 👨‍🍳

clintpurser removed their request for review

May 10, 2023 15:19


          make tests more explicit

93e45c6

purplenicole730 requested a review from bhaney

May 10, 2023 18:57

bhaney approved these changes

View reviewed changes

Member

bhaney left a comment

LGTM

purplenicole730 merged commit 1334824 into viamrobotics:main

purplenicole730 deleted the RSDK-1623-decode-custom-depth-mime-type branch

May 12, 2023 17:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet