Skip to content

Ignore Event Loop is closed error on close #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2023
Merged

Ignore Event Loop is closed error on close #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/viam/rpc/dial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,12 @@ def close(self):
if not self._closed:
try:
self.channel.close()
except RuntimeError as e:
# ignore event loop is closed errors - robot is getting shutdown
if len(e.args) > 0 and e.args[0] == "Event loop is closed":
LOGGER.debug("ViamChannel might not have shut down cleanly - Event loop was closed")
return
raise
finally:
self.release()
self._closed = True
Expand Down