Select default mime type when empty #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheukt
approved these changes
May 30, 2023
| else: | ||
| self._camera_mime_types[camera.name] = CameraMimeType.JPEG | ||
|
|
||
| request.mime_type = self._camera_mime_types[camera.name] |
There was a problem hiding this comment.
Okay so I'm not sure if we want to do any of this client side (is this client side lol?). The idea is that an empty request should be able to slide past. The server side should determine the mime type using logic like ^^ (like in RDK). I guess my question is why would we choose the request mimetype and not the response?
There was a problem hiding this comment.
@kharijarrett this is the server side but in python. So if someone is making a modular camera in python, rpc requests coming to that module would hit this code.
There was a problem hiding this comment.
Makes all the difference in the world lol this LGTM!
kharijarrett
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the mime type is empty on a
camera.get_imagerequest, python was sending back an empty mime type instead of choosing a default mime type.I basically copied what's going on in RDK, which I saw @kharijarrett implemented, so tagging him as a reviewer.
Cc: @thegreatco this should help with oakd