Skip to content

Conversation

njooma
Copy link
Member

@njooma njooma commented May 30, 2023

Needed for @thegreatco

Sets up vision as a service that can be implemented

@njooma njooma requested a review from a team as a code owner May 30, 2023 20:13
@njooma njooma requested review from maximpertsov and stuqdog May 30, 2023 20:13
@github-actions
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
camera get_image
encoder get_position
motor is_moving
sensor get_readings
servo get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
motion get_pose
vision get_detector_names

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q] why is this file changing? does this test need to add a service that is not modular?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya exactly -- these tests a service client that is just a client (no model/service)

@njooma njooma merged commit e0b5e4e into viamrobotics:main May 30, 2023
@njooma njooma deleted the RSDK-3287/vision-service branch May 30, 2023 21:38
@10zingpd 10zingpd changed the title Add vision as modular service Add vision as modular service RSDK-3353 Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants