RSDK-3292 - fix example python movement sensors #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
stuqdog
requested changes
Jun 2, 2023
tests/mocks/components.py
Outdated
| return {"command": command} | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
(nit) probably we should get rid of this newline
tests/test_robot.py
Outdated
| ResourceName(namespace="rdk", type="component", subtype="arm", name="arm1"), | ||
| ResourceName(namespace="rdk", type="component", subtype="camera", name="camera1"), | ||
| ResourceName(namespace="rdk", type="component", subtype="motor", name="motor1"), | ||
| # ResourceName(namespace="rdk", type="component", subtype="sensor", name="movement_sensor1"), |
There was a problem hiding this comment.
As a general policy, I think it's best to not have commented code committed. It is often unclear what purpose it serves/used to serve, and there's no validation that the code still works as expected. Probably best to get rid of this entirely.
|
Re-requested review after updating the tests to account for the dedupe done in generate metadata. Also added dedupe in generateStatus |
cheukt
approved these changes
Jun 5, 2023
tests/test_robot.py
Outdated
| client = RobotServiceStub(channel) | ||
| response: GetStatusResponse = await client.GetStatus(GetStatusRequest()) | ||
| assert list(response.status) == STATUSES | ||
| assert list(response.status) == (STATUSES) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up work to be done: https://viam.atlassian.net/browse/RSDK-3403