RSDK-3449: update getkinematics and getgeometries wrappers #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purplenicole730
changed the title
purplenicole730
changed the title
|
It looks like CI is failing because of issues with imports; any idea what's going on there? |
purplenicole730
force-pushed
the
RSDK-3449-update-getkinematics-and-getgeometries-wrappers
branch
from
f9bf1c3 to
9066196
Compare
benjirewis
reviewed
Jun 7, 2023
purplenicole730
deleted the
RSDK-3449-update-getkinematics-and-getgeometries-wrappers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSDK-3449 ticket
This is to get ready for the new automated proto update that introduced two new methods. The new common methods
GetKinematicsandGetGeometriesare now added to the component wrappers where needed.Service tests have also been added to confirm that a
MethodNotImplementedErroris raised.The
basecomponent now also has aGetPropertiesfunction that gives thewidthandturn radius. The PR's scope was changed to include the inclusion of this change so that all errors from the new protos update were addressed.