Skip to content

[RSDK-3418] Update readme to include connectivity docs #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2023
Merged

[RSDK-3418] Update readme to include connectivity docs #311

merged 1 commit into from
Jun 7, 2023

Conversation

njooma
Copy link
Member

@njooma njooma commented Jun 7, 2023

No description provided.

@njooma njooma requested a review from dannenberg June 7, 2023 19:23
@njooma njooma requested a review from a team as a code owner June 7, 2023 19:23
clintpurser
clintpurser approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@clintpurser clintpurser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dannenberg
dannenberg approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@dannenberg dannenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thrilled to see it! did you mean to remove the portion on the do command?

lgtm

@njooma
Copy link
Member Author

njooma commented Jun 7, 2023

thrilled to see it! did you mean to remove the portion on the do command?

Yup -- figured that it wasn't specific to the python SDK and also contained somewhat outdated information around subclassing the generic component, so that documentation is better off living in the general Viam docs

@njooma njooma merged commit d82d458 into viamrobotics:main Jun 7, 2023
@njooma njooma deleted the RSDK-3418/reconnect-docs branch June 7, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintpurser clintpurser clintpurser approved these changes

+2 more reviewers

@dannenberg dannenberg dannenberg approved these changes

@maximpertsov maximpertsov maximpertsov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@njooma @dannenberg @maximpertsov @clintpurser