Skip to content

Fix session client for Python versions <= 3.9 #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Fix session client for Python versions <= 3.9 #317

wants to merge 6 commits into from

Conversation

maximpertsov
Copy link
Contributor

@maximpertsov maximpertsov commented Jun 13, 2023 •
edited
Loading

Fixes a regression in the session client for Python versions <= 3.9 that stemmed differences in asyncio's before and after this version: https://docs.python.org/3/whatsnew/3.10.html#removed. This regression was exposed by our integration tests.

=========================== short test summary info ============================
FAILED tests/test.py::TestIntegration::test_unary - RuntimeError: Task <Task pending name='Task-6' coro=<MovementSensorClient.get_linear_velocity() running at /usr/local/lib/python3.8/site-packages/viam/components/movement_sensor/client.py:51> cb=[gather.<locals>._done_callback() at /usr/local/lib/python3.8/asyncio/tasks.py:769]> got Future <Future pending> attached to a different loop

Testing:

@maximpertsov maximpertsov marked this pull request as ready for review June 13, 2023 20:33
@maximpertsov maximpertsov requested a review from a team as a code owner June 13, 2023 20:33
@maximpertsov maximpertsov requested review from clintpurser and stuqdog and removed request for clintpurser and stuqdog June 13, 2023 20:33
@maximpertsov maximpertsov changed the title Pass in loop for python versions 3.9 and earlier Bugfix: Pass in event loop for python versions 3.9 and earlier Jun 13, 2023
@maximpertsov maximpertsov changed the title Bugfix: Pass in event loop for python versions 3.9 and earlier Fix session client for Python versions <= 3.9 Jun 13, 2023
@maximpertsov maximpertsov requested a review from njooma June 13, 2023 20:45
@maximpertsov maximpertsov changed the base branch from main to rc-0.4.0 June 13, 2023 20:49
benjirewis
benjirewis approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

njooma
njooma approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, shouldn't block merge

src/viam/sessions_client.py Outdated


def loop_kwargs():
if sys.version_info[:2] <= (3, 9):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just do if sys.version_info <= (3, 9)

@maximpertsov maximpertsov changed the base branch from rc-0.4.0 to main June 13, 2023 21:30
@maximpertsov maximpertsov mentioned this pull request Jun 13, 2023
Closed
@maximpertsov maximpertsov deleted the loop-regression branch June 13, 2023 21:57
This was referenced Jun 13, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njooma njooma njooma approved these changes

@benjirewis benjirewis benjirewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximpertsov @njooma @benjirewis @purplenicole730