-
Notifications
You must be signed in to change notification settings - Fork 64
[RSDK-3628] Create Data Location Client Able to Connect to App #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts:
- Should we have an
AppClient
similar to how we have aRobotClient
that manages the lifecycle of the connection? The call site could be something likeapp.data_client.tabular_data_by_filter(...)
- If not an
AppClient
class under which all additional app API clients fall under, then perhaps a superclass that definesconnect
andclose
, with a default implementations so that code doesn't have to be repeated for each client class?
Good questions! I agree that we should either create a broader I think I favor the following:
|
Per IRL discussion:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small requested documentation changes, but it's looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
This PR includes a new (unimplemented) data client that uses location-level authentication to make requests to app. The methods included will allow for data to be uploaded to and retrieved from app programmatically.