[RSDK-3898] Implement Tests for Data Cloud API's #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
stuqdog
requested changes
Jul 18, 2023
njooma
approved these changes
Jul 19, 2023
…ptional tuple of timestamps.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two separate test clients that combine to test every gRPC method wrapper defined in our DataClient class. Tthe PR also implements two mock services that simulate responses from app. One test client/mock service duo is for the data methods, and the other is for the data sync (upload) methods. Finally, the PR also updates binary_data_by_filter() to return a list of bytes--as opposed to a list of SensorData objects.