[hotfix] Make it such that depth images always return RawImage #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpertsov
approved these changes
Jul 19, 2023
stuqdog
approved these changes
Jul 19, 2023
cheukt
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of
CameraMimeType.VIAM_RAW_DEPTH, raw depth images are technically supported. However, they are not supported by PIL. Our current code only looks to see if the mime type is supported by viam, but not if the mime type is supported by PIL.This is a hotfix that will temporarily fix this issue. I say temporarily because once this ticket is approved and merged, it will actually be a moot point.