RSDK-3587 Add navigation service #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpertsov
force-pushed
the
RSDK-3587-update-python-sdk-to-support-navigation-service-and-move-on-globe
branch
from
cdc0b1a to
5903f3f
Compare
maximpertsov
changed the title
maximpertsov
requested review from
clintpurser,
purplenicole730 and
njooma
and removed request for
clintpurser
maximpertsov
commented
Jul 20, 2023
Comment on lines
35
to
40
| _test_watch: | ||
| poetry run ptw . | ||
|
|
||
| test_watch: | ||
| poetry run $(MAKE) _test_watch | ||
|
|
There was a problem hiding this comment.
not strictly necessary, but made adding tests much more ergonomic
There was a problem hiding this comment.
The difference between the _ and non-underscored versions should be that the underscored version should be the naked command (without poetry run), and the non-underscored version should run the _underscored version with poetry run.
There was a problem hiding this comment.
whoops - good catch
njooma
requested changes
Jul 20, 2023
Comment on lines
35
to
40
| _test_watch: | ||
| poetry run ptw . | ||
|
|
||
| test_watch: | ||
| poetry run $(MAKE) _test_watch | ||
|
|
There was a problem hiding this comment.
The difference between the _ and non-underscored versions should be that the underscored version should be the naked command (without poetry run), and the non-underscored version should run the _underscored version with poetry run.
njooma
approved these changes
Jul 20, 2023
maximpertsov
deleted the
RSDK-3587-update-python-sdk-to-support-navigation-service-and-move-on-globe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.