Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Jul 21, 2023

This PR adds a static helper method to the DataClient class that can be used to create a Filter object. The PR also updates the docs accordingly and includes implicit testing (i.e., there's no single unit test for the method, but the method is used to create a Filter and that filter is compared to /asserted against a separate, hard-coded Filter in other tests).

@ghost ghost requested review from njooma and stuqdog July 21, 2023 17:41
@ghost ghost self-requested a review as a code owner July 21, 2023 17:41
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ghost ghost merged commit 89bcaed into viamrobotics:main Jul 26, 2023
@ghost ghost deleted the RSDK-4113/add-filter-method branch July 26, 2023 17:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants