[RSDK-3639] Create Location Client #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
One thing worth double checking is the format of the logs that I output as a result of passing a filepath 'dest' to get_robot_part_logs(): |
njooma
requested changes
Jul 26, 2023
There was a problem hiding this comment.
Some changes:
- Need tests
- Why are robot/robot part/fragment/role/etc. methods here? These seem like app apis, not location APIs
- Default to getting all logs seems like not a great idea. It could take a really really long time and also the memory footprint of the result could be very large. I think we paginate
- Some basic formatting requests
stuqdog
requested changes
Jul 27, 2023
There was a problem hiding this comment.
Nice, this is looking pretty good! Some requested semantic/documentation changes, and piggy backing on some of Naveed's points. I generally agree with his high level comments, and added some brief thoughts on splitting up the robot APIs into a separate client.
stuqdog
requested changes
Jul 28, 2023
stuqdog
reviewed
Jul 28, 2023
stuqdog
approved these changes
Jul 28, 2023
cheukt
reviewed
Jul 28, 2023
njooma
requested changes
Jul 28, 2023
stuqdog
requested changes
Aug 1, 2023
There was a problem hiding this comment.
(q) a bit of a tangent, but why do we check this in at all? seems like a good thing to put in the .gitignore
…ead of number of log pages.
stuqdog
approved these changes
Aug 1, 2023
njooma
approved these changes
Aug 1, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements our LocationClient class, a class that exposes methods that make calls to the location service, and adds it as a property under out AppClient class. Right now, only the methods that've been labeled as high-priority have been implemented. The class also includes 3 shadow classes that essentially copy proto-defined classes but convert the Structs within those definitions to dictionaries and some Timestamps to Python datetimes. This specific PR also includes docstrings for the class. I'll make separate tickets and PR's for adding a snippet in the example notebook showing how to use the location_client and also some unit tests that depend on a mock location service.