Rename sensor to imager

[npentrel]

Am I misunderstanding this or are we using sensor as a synonym

[github-actions]

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component	function
base	is_moving
board	gpio_pin_by_name
camera	get_image
encoder	get_position
motor	is_moving
sensor	get_readings
servo	get_position
arm	get_end_position
gantry	get_lengths
gripper	is_moving
movement_sensor	get_linear_acceleration
input_controller	get_controls
audio	get_properties
pose_tracker	get_poses
motion	get_pose
vision	get_classifications_from_camera

[njooma]

This is fine by me but this text was copied from RDK so we should change there as well cc @bazile-clyde

[bazile-clyde]

@npentrel I didn't write this but I suspect the reason the word "camera" wasn't used is because this method was implemented for the Intel Real Sense.

That is one camera with multiple "imagers" as they call it. Each takes a separate image and we use the timestamps to confirm both images were taken at roughly the same time.

To answer your question, no, "sensor" was not used synonymously with "camera". However, I'm not opposed to changing the word here, though, "camera" might be a bit overloaded since now it's referring to the imagers and the camera housing the imagers, the camera component.

[npentrel]

should we use imgers then?

[bazile-clyde]

@npentrel imagers would be fine by me.

[njooma]

@npentrel has there been any movement on this? I fear it becoming stale...

[npentrel]

let me find the pr on the rdk and ask there - and then I'll follow up here

[npentrel]

Ok - @bhaney added the RDK code - what do you think Bijan - should we change this to imagers?

[bazile-clyde]

Ok - @bhaney added the RDK code - what do you think Bijan - should we change this to imagers?

@npentrel He's OOO for about two weeks, and my team owns this code. I'm okay with leaving it as is or changing it to "imagers."

[npentrel]

ok let's do imagers then

[npentrel]

viamrobotics/rdk#2833

[npentrel]

@bazile-clyde ok to merge?

[bazile-clyde]

LGTM!