[RSDK 4604] Refine Examples & Refactor Code #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
stuqdog
approved these changes
Aug 22, 2023
njooma
approved these changes
Aug 22, 2023
purplenicole730
approved these changes
Aug 22, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code makes a few "cosmetic" changes to some of the classes housed within the 'app' directory and some of our documentation. Namely, the examples notebook is updated to make the output of a code cell more readable. A few docstrings within the clients are updated/corrected/reworded. An assertion error is swapped out for a value error. The last changes are an update to the tabular data methodology mechanism and the elimination of some redundant conditional logic in the filter helper method.