Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2023

This PR adds a custom base model within the 'examples' subdirectory as a guide/template for users to follow. The new additions are loosely based on the file 'my_base.py' found at the bottom of this webpage, and also the parallel example in the Go SDK here.

This is a draft for now due to a local bug that I've been unable to fix.. stay tuned!

@ghost ghost requested review from njooma and cheukt August 23, 2023 23:29
@ghost
Copy link
Author

ghost commented Aug 25, 2023

@njooma @cheukt pulling this out of draft status! Everything was locally tested using a local viam-server instance and the script found in viam-python-sdk/examples/complex_modules/client.py.

@ghost ghost marked this pull request as ready for review August 25, 2023 15:07
@ghost ghost self-requested a review as a code owner August 25, 2023 15:07
@ghost ghost requested a review from dgottlieb August 25, 2023 15:07
@ghost ghost requested a review from cheukt August 25, 2023 15:47
Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cheukt cheukt merged commit 8659416 into viamrobotics:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants