Skip to content

RSDK-4890 - Fix location_auth return type + navigation docs in docs #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2023
Merged

RSDK-4890 - Fix location_auth return type + navigation docs in docs #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1ec907
fix
cheukt Sep 12, 2023
66987e5
update nav
cheukt Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/viam/app/app_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ async def location_auth(self, location_id: Optional[str] = None) -> LocationAuth
instantiation.

Returns:
LocationAuth: The `LocationAuth` containing location secrets.
viam.proto.app.LocationAuth: The `LocationAuth` containing location secrets.
"""
request = LocationAuthRequest(location_id=location_id if location_id else self._location_id if self._location_id else "")
response: LocationAuthResponse = await self._app_client.LocationAuth(request, metadata=self._metadata)
Expand Down
2 changes: 1 addition & 1 deletion src/viam/services/navigation/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

class NavigationClient(Navigation, ReconfigurableResourceRPCClientBase):
"""
Connect to the NavigationService, which allows the robot to create a map of its surroundings and find its location in that map.
Connect to the NavigationService, which allows the robot to navigate to specified locations.
"""

client: NavigationServiceStub
Expand Down
2 changes: 1 addition & 1 deletion src/viam/services/navigation/navigation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class Navigation(ServiceBase):
Navigation represents a Navigation service.

This acts as an abstract base class for any drivers representing specific
arm implementations. This cannot be used on its own. If the ``__init__()`` function is
navigation service implementations. This cannot be used on its own. If the ``__init__()`` function is
overridden, it must call the ``super().__init__()`` function.
"""

Expand Down