RSDK-4895: Make numpy an extra dependency #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy only; changed imports to try/except and warn users on import of the mlmodel module
hexbabe
commented
Sep 13, 2023
hexbabe
commented
Sep 13, 2023
cheukt
reviewed
Sep 13, 2023
hexbabe
changed the title
…ordingly; made tests have less irrelevant warnings
hexbabe
commented
Sep 13, 2023
cheukt
requested changes
Sep 13, 2023
andf-viam
reviewed
Sep 14, 2023
njooma
requested changes
Sep 14, 2023
added 2 commits
September 14, 2023 15:39
…ency for numpy from pyproject.toml; Added extras flag in make file install command
njooma
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://viam.atlassian.net/browse/RSDK-4895
Changed pyproject.toml to not require numpy, adding it as an extra/dev dependency only; changed np imports to try/except and warn users on import of the mlmodel module
Tested locally with .whl file and [mlmodel] flag in venv