Skip to content

Require extra deps in all workflows #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Require extra deps in all workflows #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/license_finder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_dispatch:
workflow_call:
pull_request:
branches: ['main']
branches: ["main"]

jobs:
license_finder:
Expand All @@ -26,7 +26,7 @@ jobs:
uses: snok/install-poetry@v1

- name: Install package
run: poetry install
run: poetry install --all-extras

- name: Generate requirements.txt (exclude dev dependencies)
run: |
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/release-candidate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ on:
workflow_dispatch:
inputs:
version:
description: 'The type of version bump. All versions will have `rc*` appended. `rc` version bumps will happen automatically, so select the type of version bump for the final release. Use `-s` for no change.'
description: "The type of version bump. All versions will have `rc*` appended. `rc` version bumps will happen automatically, so select the type of version bump for the final release. Use `-s` for no change."
type: choice
required: true
default: '-s'
default: "-s"
options:
- major
- minor
- patch
- '-s'
- major
- minor
- patch
- "-s"

jobs:
prepare:
Expand All @@ -33,7 +33,7 @@ jobs:
with:
organization: viamrobotics
username: ${{ github.actor }}
token: ${{ secrets.GITHUB_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}

- name: Cancelling - user not part of organization
uses: andymckay/cancel-action@0.2
Expand All @@ -56,7 +56,7 @@ jobs:
uses: snok/install-poetry@v1

- name: Install Package
run: poetry install
run: poetry install --all-extras

- name: Clean Format Test
run: make clean better_imports format test
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
releaseName: v${{ env.SDK_RC_VERSION }}
doNotFailIfNotFound: 'true'
doNotFailIfNotFound: "true"

- name: Cancelling - release already exists
uses: andymckay/cancel-action@0.2
Expand Down Expand Up @@ -141,7 +141,7 @@ jobs:
uses: snok/install-poetry@v1

- name: Install package
run: poetry install
run: poetry install --all-extras

- name: Download binary
run: curl -sL -o src/viam/rpc/libviam_rust_utils.${{ matrix.ext }} https://github.com/viamrobotics/rust-utils/releases/latest/download/libviam_rust_utils-${{ matrix.arch }}.${{ matrix.ext }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
with:
organization: viamrobotics
username: ${{ github.actor }}
token: ${{ secrets.GITHUB_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}

- name: Cancelling - user not part of organization
uses: andymckay/cancel-action@0.2
Expand All @@ -32,7 +32,7 @@ jobs:
uses: snok/install-poetry@v1

- name: Install Package
run: poetry install
run: poetry install --all-extras

- name: Clean Format Test
run: make clean better_imports format test
Expand All @@ -52,7 +52,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
releaseName: v${{ env.SDK_VERSION }}
doNotFailIfNotFound: 'true'
doNotFailIfNotFound: "true"

- name: Cancelling - release already exists
uses: andymckay/cancel-action@0.2
Expand Down Expand Up @@ -106,7 +106,7 @@ jobs:
uses: snok/install-poetry@v1

- name: Install package
run: poetry install
run: poetry install --all-extras

- name: Download binary
run: curl -sL -o src/viam/rpc/libviam_rust_utils.${{ matrix.ext }} https://github.com/viamrobotics/rust-utils/releases/latest/download/libviam_rust_utils-${{ matrix.arch }}.${{ matrix.ext }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/update_protos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
uses: snok/install-poetry@v1

- name: Install package
run: poetry install
run: poetry install --all-extras

- name: Generate buf
run: make buf
Expand All @@ -41,8 +41,8 @@ jobs:
- name: Add + Commit + Open PR
uses: peter-evans/create-pull-request@v5
with:
commit-message: '[WORKFLOW] Updating protos from ${{ github.event.client_payload.repo_name }}, commit: ${{ github.event.client_payload.sha }}'
branch: 'workflow/update-protos'
commit-message: "[WORKFLOW] Updating protos from ${{ github.event.client_payload.repo_name }}, commit: ${{ github.event.client_payload.sha }}"
branch: "workflow/update-protos"
delete-branch: true
base: main
title: Automated Protos Update
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ allowlist_externals =
make
recreate = True
commands =
poetry install
poetry install --all-extras
make test_docs