Skip to content

RSDK-5175 - return file upload server error #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2023
Merged

RSDK-5175 - return file upload server error #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21b14df
raise appropriate err
stuqdog Nov 6, 2023
9be1955
add in other places
stuqdog Nov 7, 2023
134374c
linter fix
stuqdog Nov 7, 2023
0556e03
fix wrong error throwing
stuqdog Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/viam/app/app_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,7 +1170,8 @@ async def upload_module_file(self, module_file_info: Optional[ModuleFileInfo], f
await stream.send_message(request_module_file_info)
await stream.send_message(request_file, end=True)
response = await stream.recv_message()
assert response is not None
if not response:
await stream.recv_trailing_metadata() # causes us to throw appropriate gRPC error.
return response.url

async def get_module(self, module_id: str) -> Module:
Expand Down
3 changes: 2 additions & 1 deletion src/viam/app/data_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,8 @@ async def _file_upload(self, metadata: UploadMetadata, file_contents: FileData)
await stream.send_message(request_metadata)
await stream.send_message(request_file_contents, end=True)
response = await stream.recv_message()
assert response is not None
if not response:
await stream.recv_trailing_metadata() # causes us to throw appropriate gRPC error.
return response

@staticmethod
Expand Down
4 changes: 3 additions & 1 deletion src/viam/components/audio_input/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ async def read() -> AsyncIterator[Audio]:
ChunksRequest(name=self.name, sample_format=SampleFormat.SAMPLE_FORMAT_FLOAT32_INTERLEAVED), end=True
)
response: Union[ChunksResponse, None] = await chunks_stream.recv_message()
assert response is not None and response.HasField("info")
if not response:
await chunks_stream.recv_trailing_metadata() # causes us to throw appropriate gRPC error.
assert response.HasField("info")
info = response.info

while True:
Expand Down