RSDK-4650 - Add streaming data capture upload #486
Conversation
| sensor_contents = SensorData( | ||
| metadata=( | ||
| SensorMetadata( | ||
| time_requested=datetime_to_timestamp(data_request_times[0]) if data_request_times[0] else None, |
There was a problem hiding this comment.
(flyby) this would have caused a runtime error in cases where the (ostensibly optional) tuple was None.
| SensorData( | ||
| metadata=( | ||
| SensorMetadata( | ||
| time_requested=datetime_to_timestamp(data_request_times[idx][0]) if data_request_times[idx][0] else None, |
There was a problem hiding this comment.
(flyby) this would have caused a runtime error in cases where the (ostensibly optional) list of tuples was None.
| time_requested=datetime_to_timestamp(data_request_times[0]) if data_request_times[0] else None, | ||
| time_received=datetime_to_timestamp(data_request_times[1]) if data_request_times[1] else None, | ||
| time_requested=datetime_to_timestamp(data_request_times[0]) if data_request_times else None, | ||
| time_received=datetime_to_timestamp(data_request_times[1]) if data_request_times else None, |
There was a problem hiding this comment.
What if data_request_times[0] and not data_request_times[1]? Same question below.
There was a problem hiding this comment.
So data_request_times is annotated as an Optional[Tuple[datetime, datetime]], not a Tuple[Optional[datetime], Optional[datetime]], so there should either be a tuple with two Somes or a None. So I think the case you're describing is one that's inconsistent with how we expect input. Definitely open to discussing changing what we expect though!
There was a problem hiding this comment.
Ah no I misunderstood the typing; that sounds right to me thanks for the context!
| component_type (Optional[str]): Optional type of the component associated with the file (e.g., "movement_sensor"). | ||
| component_name (Optional[str]): Optional name of the component associated with the file. | ||
| method_name (Optional[str]): Optional name of the method associated with the file. | ||
| method_parameters (Optional[str]): Optional dictionary of the method parameters. No longer in active use. |
There was a problem hiding this comment.
What does "No longer in active use" mean? Should we not even have this parameter in the SDK if it's "deprecated"?
There was a problem hiding this comment.
Yeah, good question! The no longer in active use language is cribbed from how method_parameters is annotated elsewhere in the SDK. I don't remember the details precisely, but I remember conversations with the data team basically being "We don't use this now, but we should still allow it to be passed because it does update on the backend."
There was a problem hiding this comment.
Cool; so sort just short of deprecated. Seems fine to me, just wanted to call out.
Implements
streaming_data_capture_upload