[DATA-2065] Make data required in file upload #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
@purplenicole730 probably has more context than I do, but seems good!
|
@purplenicole730 is on vacay, so pinging @stuqdog instead |
stuqdog
reviewed
Nov 16, 2023
| response = await stream.recv_message() | ||
| if not response: | ||
| await stream.recv_trailing_metadata() # causes us to throw appropriate gRPC error | ||
| raise TypeError("Response cannot be empty") |
There was a problem hiding this comment.
(q) Is it possible for us to actually reach this point? if not response is the case when the response isn't just empty, but a None, which I think should only happen if something went wrong such that we'd have a non-OK gRPC status and so throw an error at the preceding line. I guess either way there's no harm in having another safety rail here!
There was a problem hiding this comment.
WE know we can't get here, but the typechecker doesn't know that and it was complaining
stuqdog
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.