RSDK-5390 - [BREAKING] MoveOnGlobe definition change #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksanford
force-pushed
the
RSDK-5390
branch
from
cc36e61 to
e9c5e71
Compare
nicksanford
changed the title
|
@njooma this PR depends on the latest api definition ( |
|
@nicksanford The new protos are in this PR: #505 You can test using this. If you want me to merge it in, LMK and we can do that too |
|
@njooma If possible I'd like to get the protos & this PR merged this week so the python SDKS are compatible with the next stable version of viam server. |
|
@nicksanford You'll have to pull in the changes from the automated PR in order to get the updated protos in order for this PR to pass tests, and then we can merge it all in this week |
nicksanford
force-pushed
the
RSDK-5390
branch
from
e9c5e71 to
555f52c
Compare
nicksanford
force-pushed
the
RSDK-5390
branch
from
060e2dc to
7e06f6d
Compare
nicksanford
force-pushed
the
RSDK-5390
branch
from
7e06f6d to
cb79ccf
Compare
nicksanford
force-pushed
the
RSDK-5390
branch
from
cc6e5a4 to
69afb6b
Compare
njooma
added a commit
that referenced
this pull request
Dec 22, 2023
Co-authored-by: njooma <njooma@users.noreply.github.com> Co-authored-by: Naveed Jooma <naveed@viam.com>
nicksanford
added a commit
to nicksanford/viam-python-sdk
that referenced
this pull request
Jan 29, 2024
Co-authored-by: njooma <njooma@users.noreply.github.com> Co-authored-by: Naveed Jooma <naveed@viam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Depends on:
RDK: viamrobotics/rdk#3303
Previous SDK change: #500
API change: viamrobotics/rdk#3303