Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer working with Ecto 2.0-beta #1

Closed
johnhamelink opened this issue Mar 9, 2016 · 3 comments
Closed

No longer working with Ecto 2.0-beta #1

johnhamelink opened this issue Mar 9, 2016 · 3 comments

Comments

@johnhamelink
Copy link
Contributor

Hey there,

The breaking changes introduced in 2.0-beta have caused params to break (thankfully its tests also break in the same way). I'm working on a PR to fix this right now, but in the meantime, here's the sort of errors I'm experiencing:

Compiled lib/params/def.ex
** (Protocol.UndefinedError) protocol Enumerable not implemented for :id
    (elixir) lib/enum.ex:1: Enumerable.impl_for!/1
    (elixir) lib/enum.ex:116: Enumerable.reduce/3
    (elixir) lib/enum.ex:1486: Enum.reduce/3
    test/params_test.exs:10: (module)
    test/params_test.exs:8: (module)
== Compilation error on file lib/params.ex ==
** (CompileError) lib/params.ex:77: unknown key :model for struct Ecto.Changeset
    (elixir) src/elixir_map.erl:185: :elixir_map."-assert_struct_keys/5-lc$^0/1-0-"/5
    (elixir) src/elixir_map.erl:62: :elixir_map.translate_struct/4
    (stdlib) lists.erl:1353: :lists.mapfoldl/3
@johnhamelink
Copy link
Contributor Author

Some information @mitchellhenke and I have gathered over Slack:

johnhamelink added a commit to johnhamelink/params that referenced this issue Mar 9, 2016
vic added a commit that referenced this issue Mar 10, 2016
Thanks to @johnhamelink for initial work on this.
@vic
Copy link
Owner

vic commented Mar 10, 2016

Hey, thanks for your work on getting this working with ecto 2.

I've created a new branch ecto-2.x and released a new version

I'll merge on master as soon as ecto 2 gets out of beta.

@johnhamelink
Copy link
Contributor Author

@vic you are a beautiful human being 😄 Thanks for putting this out so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants