Skip to content
This repository was archived by the owner on Dec 1, 2021. It is now read-only.

feat: support ignoreNoneParent #20

Closed
wants to merge 10 commits into from
Closed

feat: support ignoreNoneParent #20

wants to merge 10 commits into from

Conversation

sqlwwx
Copy link
Contributor

@sqlwwx sqlwwx commented Oct 16, 2019

No description provided.

@coveralls
Copy link

coveralls commented Oct 16, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.6%) to 89.121% when pulling 269d3b4 on sqlwwx:master into c27f5d1 on vicanso:master.

vicanso
vicanso reviewed Oct 27, 2019
View reviewed changes
Copy link
Owner

@vicanso vicanso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may adversely affect performance of calling cleanNoDataParent in before function.

@sqlwwx
Copy link
Contributor Author

sqlwwx commented Oct 27, 2019

I think it may adversely affect performance of calling cleanNoDataParent in before function.

Do you have any other way to solve loop problem.

@sqlwwx sqlwwx closed this Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@vicanso vicanso vicanso left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sqlwwx @coveralls @vicanso