Move Vico to 10.8 SDK and ARC #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned This also starts the process of getting the XCode project building again. That said, while XCode successfully builds the binary, it won't run. And the makefile isn't building successfully yet. More to come.
We've changed ViTaskRunner to always invoke the same selector on its target. Targets should use contextInfo to disambiguate between multiple possible callback targets. The change was already implemented, but there was still a vestigial _selector instance variable in the ViTaskRunner class.
contextInfo is now always a dictionary with a type key. The @"type" key is used to decide which callback to use. To avoid warnings, we have a protocol with the two methods that the bundle_commands and vi_commands categories define as callbacks for the task runner marked as optional.
Since we're targeting OS X 10.8+, we don't need to accommodate Leopard-.
This lets us use ARC on SBJsonParser, as well.
Everything now builds via makefile, but we explode at runtime.
Same crashiness at runtime, though.
We'll see what happens memory-retention wise… But right now this causes crashes.
We'll want to re-profile this to figure out where we actually want weaks. It seems like before we were relying on certain weaks not being released at the appropriate times, and now that ARC is doing the releasing for us they're causing some serious issues.
In fact, they were probably downright dangerous…
I screwed this up while porting. My b.
This was returning in the opposite of the situation it was supposed to do so in, so keystrokes weren't getting through.
|
This is now behaving and seems to be working. I'll be using the branch for a few days to see if anything explodes in my face. |
Conflicts: app/ViCompletion.h app/ViCompletion.m app/ViCompletionController.m app/ViKeyManager.m
|
No picture of the arc reactor? Really?! :P |
|
I opened the issue before there was a branch :p. I'll add it in now though |
The ARC converter marked it weak because it's an outlet, but that was breaking preferences.
This via mega-hack, but it works for now. Hopefully we'll figure out a better solution long term.
We're now setting up the inset in ExTextField instead of changing the origin at request time in ViTextView. This seems to not be buggy at the moment, we'll see if it holds up.
We also have the groundwork for highlighting what is typed into the ex line.
|
Notably, this doesn't seem to compile correctly on some versions of XCode/LLVM. There are issues with |
Hopefully this doesn't totally break SFTPConnection...
|
Ok, let's play this game. Merge-time. |
Shadowfiend
added a commit
that referenced
this pull request
Sep 21, 2013
Move Vico to 10.8 SDK and ARC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yep, this is a crazy one…
Image credit flickr user NathanielS