Fixed bug in password to-char-array #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cast to (char[]) will always fail for String. The String class has the method "toCharArray()" to do the conversion. Note that the MQTT example uses the key "username" instead of "user".
Proper cast to String
|
@topherCantrell thx for the pull request, I just updated the examples to match the user field |
|
Oh man! Thank YOU for the awesome library! Sooooo great!
…On Fri, Jul 3, 2020 at 3:43 PM Victor Diaz ***@***.***> wrote:
@topherCantrell <https://github.com/topherCantrell> thx for the pull
request, I just updated the examples to match the user field
***@***.***
<victordiaz/PHONK-examples@8c79af2>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKK6QOQROOOUNBDEI7XVWLRZY7F3ANCNFSM4OQA4QBA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cast to (char[]) will always fail for String. The String class has the method "toCharArray()" to do the conversion. Note that the MQTT example uses the key "username" instead of "user".