Paused canplay #139
Paused canplay #139
Conversation
This is already done in play.
Trigger canplay immediately after loadedmetadata.
| @@ -261,7 +261,6 @@ package com.videojs.providers{ | |||
| public function load():void{ | |||
| _pauseOnStart = true; | |||
| _isPlaying = false; | |||
| _isPaused = true; | |||
There was a problem hiding this comment.
Paused is supposed to be true by default. Is this going to change that?
There was a problem hiding this comment.
It's the default
But we might need to make sure it's paused at the end of a video.
There was a problem hiding this comment.
It's paused at the end of the video and before the video has started playing.
|
Good stuff. Was this meant to fix something specific, or just cleanup? Should definitely get other eyes on this as I'm not super familiar with ye old netstream. We should also do some testing around different play/pause/autoplay/preload/source change combinations to be sure this doesn't change the behavior. |
|
We were testing this with ads in a single player, with and without autoplay. So, it should work pretty well. |
|
This LGTM. Definitely needed improvement. I would just question whether or not the other providers should exhibit the same functionality for normalization. |
|
Merging it in since we have two LGTM. We should get this released ASAP. |
Better handling of ye old netstream.