This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
hard coded callbacks to avoid XSS. Closes #142 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if(loaderInfo.parameters.eventProxyFunction != undefined){ | ||
|
|
||
| // Hard coding these in for now until we can come up with a better solution for 5.0 to avoid XSS. | ||
| _app.model.jsEventProxyName = 'videojs.Flash.onEvent'; |
There was a problem hiding this comment.
the code that uses this doesn't need to be changed?
There was a problem hiding this comment.
We need to remove these settings from core.
https://github.com/videojs/video.js/blob/master/src/js/media/flash.js#L39
There was a problem hiding this comment.
I also meant whether any changes in the swf are needed where these are used. It sounds like it doesn't.
|
Other than question on usage, LGTM. |
heff
added a commit
that referenced
this pull request
Mar 17, 2015
hard coded callbacks to avoid XSS. Closes #142
heff
added a commit
to heff/video-js-swf
that referenced
this pull request
Mar 17, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.