Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtitles are not showing because weird internal error. #41

Closed
Almo7aya opened this issue Sep 29, 2019 · 7 comments
Closed

Subtitles are not showing because weird internal error. #41

Almo7aya opened this issue Sep 29, 2019 · 7 comments

Comments

@Almo7aya
Copy link

Hello
I'm using video.js with HLS videos the subtitles are specified in the m3u8 file.
I'm facing this error every time a cue should appear
Annotation 2019-09-29 170205
@Almo7aya
Copy link
Author

Almo7aya commented Sep 29, 2019 •
edited
Loading

This issue has been fixed in the original repo mozilla/vtt.js#371 can anyone update the package? please.

Almo7aya added a commit to Almo7aya/vtt.js that referenced this issue Sep 29, 2019
@Almo7aya
Remove errored readonly assignment videojs#41
57aa992
Almo7aya added a commit to Almo7aya/vtt.js that referenced this issue Sep 29, 2019
@Almo7aya
Remove errored readonly assignment videojs#41 (#1)
7fa5f4b 
Remove errored readonly assignment videojs#41
@gkatsev
Copy link
Member

gkatsev commented Oct 1, 2019

We have a PR for it as well #40. Haven't gotten around to merging and releasing it yet.

@Almo7aya
Copy link
Author

The PR has been merged, can anyone create a new release, please.

@gkatsev
Copy link
Member

gkatsev commented Nov 26, 2019

I'm going to be working on releasing vtt.js this week.

@gkatsev
Copy link
Member

gkatsev commented Nov 26, 2019

Just published 0.15.0 with this change.

@gkatsev gkatsev closed this as completed Nov 26, 2019
@Almo7aya
Copy link
Author

Great thank you very much

@gkatsev
Copy link
Member

gkatsev commented Nov 27, 2019

It is up on npm https://www.npmjs.com/package/videojs-vtt.js/v/0.15.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gkatsev @Almo7aya