Eliminate internal Presenter wrapper shouldComponentUpdate #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shouldComponentUpdate is implemented within a special context "sock" inside of the presenter. This wrapper exists to ensure that React context is properly transferred over when extending Presenters. IE10 or lower doesn't transfer static members for ES6 classes.
The reason I did this was to prevent the view model from recalculating too many times when an app changes. If a parent is going to render anyway, there's no sense in recalculating the model when the presenter's subscription fires. Just do it all in the same render.
This commit removes that shouldComponentUpdate method and re-works the efficiency test to test against the model recalculation, not re-render.
Fixes #188