Skip to content

Conversation

nhunzaker
Copy link
Contributor

@nhunzaker nhunzaker commented Dec 1, 2016

shouldComponentUpdate is implemented within a special context "sock" inside of the presenter. This wrapper exists to ensure that React context is properly transferred over when extending Presenters. IE10 or lower doesn't transfer static members for ES6 classes.

The reason I did this was to prevent the view model from recalculating too many times when an app changes. If a parent is going to render anyway, there's no sense in recalculating the model when the presenter's subscription fires. Just do it all in the same render.

This commit removes that shouldComponentUpdate method and re-works the efficiency test to test against the model recalculation, not re-render.


Fixes #188

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ec6f128 on presenter-state into 220c38e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 443a03f on presenter-state into 443a03f on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants