Allow custom repo behavior in Presenter #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an extendable getRepo method to the Presenter
prototype that allows custom repo assignment behavior. For example, if
we wanted to avoid the default forking behavior:
```javascript
class NoFork extends Presenter {
getRepo (repo) {
return repo
}
}
```
cwmanning
reviewed
Jan 5, 2017
| ```javascript | ||
| class NoFork extends Presenter { | ||
| getRepo (repo) { | ||
| return repo |
There was a problem hiding this comment.
what about an inline comment clarifying that this is a new Microcosm?
There was a problem hiding this comment.
This is the same repo given to the Presenter (unless no repo is given). Is that what you mean?
There was a problem hiding this comment.
ahh ok, ignore this one. I was thinking something different.
|
👍 |
greypants
approved these changes
Jan 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an extendable getRepo method to the Presenter
prototype that allows custom repo assignment behavior. For example, if
we wanted to avoid the default forking behavior: