Reset and patch reject when deserialize fails. Add new test helper #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mackermedia
reviewed
Feb 16, 2017
| toHaveStatus (action, status) { | ||
| if (action instanceof Action === false) { | ||
| throw new TypeError("toHaveStatus expects an Action. Received " + | ||
| (action ? "a " + action.constructor.name : action) + ".") |
There was a problem hiding this comment.
You want to return null if no action on the second ternary return value? Might be easier to read by explicitly having null there?
There was a problem hiding this comment.
I want to account for other values, like undefined, a string, or a number, or something else. This at least calls toString on it.
There was a problem hiding this comment.
Ah.. hmm. I see your point though. It'll be confusing to read:
expect("foobar").toHaveStatus("closed")
toHaveStatus expects an Action. Received "foobar".
Instead of:
"toHaveStatus expects an Action. Received a String."
What's better in your opinion?
|
👍 |
nhunzaker
force-pushed
the
deserialize-and-test-helpers
branch
from
630ae36 to
291dc8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset and patch return an action. This PR sets those actions up so that they are rejected whenever deserializing their payloads fail.
Deserialize still raises an exception.
I've also added a new test helper for quickly testing repo state in a safe way.