Add Rails 4 support #9

zporter · 2014-09-10T19:58:45Z

Quite a few things needed to be addressed to make this happen:

Bump AR version in gemspec
Use Ruby's 1.9+ MiniTest instead of TestUnit.
This test was failing due to the except option here. "email" was replaced with "name".
The encode method within ActiveSupport calls dup on options. When using to_json, we were allowing the Symbol for set to be passed to this method. dup cannot be called on Symbol, so to_json had to be added back as a method that we parse the options for.

Quite a few things needed to be addressed to make this happen: Bump AR version in gemspec. The test at the following line was failing due to the `except` option. "email" was replaced with "name". https://github.com/vigetlabs/serialize_with_options/blob/d792a472431c72b93dd00b14e7654a8f2c7ebb89/test/serialize_with_options_test.rb#L184 The `encode` method within ActiveSupport calls `dup` on `options`. When using `to_json`, we were allowing the Symbol for `set` to be passed to this method. `dup` cannot be called on Symbol, so `to_json` had to be added back as a method that we parse the options for. Here's the offending line in Rails: https://github.com/rails/rails/blob/4-1-6/activesupport/lib/active_support/json/encoding.rb#L34

dce · 2014-09-10T20:02:02Z

👍 💯

mackermedia · 2014-09-10T20:04:27Z

Noice 🍬

dce merged commit 152a5a6 into master Sep 10, 2014

dce deleted the rails-4 branch September 10, 2014 20:14

Provide feedback