Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compatible with AGP 8 #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make compatible with AGP 8 #81

wants to merge 1 commit into from
+5 −0

Conversation

ciriousjoker
Copy link
Collaborator

  • Adds a namespace to make it compatible with Android Gradle Plugin (AGP) 8
  • Solution copied from the cloud_firestore package, so it's still backwards compatible with AGP <4.2

@ciriousjoker
Copy link
Collaborator Author

@vikram25897 Could you please review this?

@wildsurfer wildsurfer mentioned this pull request Jul 12, 2024
Open
@rednikisfun
Copy link

Any news on this? The package that depends on cached_video_player is causing trouble at the build, and the whole project's android version became at stale. If there's no update on this soon, I'll have to switch to a different player solution.

@javeke
Copy link

javeke commented Nov 29, 2024

Hey I love the work that was done on this package. Would you be merging this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram25897 vikram25897 Awaiting requested review from vikram25897

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ciriousjoker @rednikisfun @javeke