Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert project to Monorepo: Part 1 #58

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

AnastasiiaPlutalova
Copy link
Contributor

No description provided.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
addon/package.json Show resolved Hide resolved
@@ -15,6 +15,7 @@ jobs:
test:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnastasiiaPlutalova please adjust floating and try-scenarios as well to set working-directory

Copy link
Contributor Author

@AnastasiiaPlutalova AnastasiiaPlutalova Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeAstapov added working-directory: test-app to floating and try-scenarios. Is working-directory: addon needed for them?

@villander villander changed the title V2 addon Convert project to Monorepo Feb 11, 2022
@AnastasiiaPlutalova AnastasiiaPlutalova changed the title Convert project to Monorepo Convert project to Monorepo: Part 1 Feb 25, 2022
@villander
Copy link
Owner

villander commented Feb 26, 2022

@SergeAstapov @AnastasiiaPlutalova there's no CI running here, could you please fix that?

@SergeAstapov
Copy link
Contributor

First-time contributors need a maintainer to approve running workflows.

@villander you need to approve PR to run CI :)

@villander villander merged commit e3b1151 into villander:master Mar 2, 2022
@villander villander added dependencies Pull requests that update a dependency file enhancement New feature or request and removed dependencies Pull requests that update a dependency file labels Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants