Skip to content

Conversation

ryoppippi
Copy link
Member

#338 に関連して、 page storeがdeprecatedになっていたものを置き換え
404ページが普通に動けば問題なし

@ryoppippi ryoppippi requested review from Copilot and staticWagomU May 15, 2025 11:30
@ryoppippi ryoppippi enabled auto-merge May 15, 2025 11:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the deprecated '$app/stores' import with the updated '$app/state' import for the 'page' store, aligning with the changes required for the 404 page functionality.

  • Updated the import statement for the 'page' store.
  • Adjusted the usage of the store in the error render block by removing the '$' prefix.
Comments suppressed due to low confidence (1)

src/routes/+error.svelte:4

  • Confirm that using 'page' without the '$' prefix aligns with the new reactive store API provided by '$app/state', as this change differs from the auto-subscription pattern used with '$app/stores'.
import { page } from '$app/state';

Copy link

Deploying vim-jp-radio-lp with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7cda2cc
Status: ✅  Deploy successful!
Preview URL: https://46e4f42e.lp-d1f.pages.dev
Branch Preview URL: https://fix-store.lp-d1f.pages.dev

View logs

Copy link
Contributor

@staticWagomU staticWagomU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404動きました!
!!!!!LGTM!!!!!

@ryoppippi ryoppippi merged commit bbd8a57 into main May 15, 2025
3 checks passed
@ryoppippi ryoppippi deleted the fix-store branch May 15, 2025 12:18
@ryoppippi
Copy link
Member Author

@staticWagomU ありがとうございます

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants