Run check.vim when testing #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
もうちょっと見てみますが、速報ということで。 これ試してみたんですが、手元では常に失敗扱いになりますね… |
|
あーWin ( |
|
うはっ ちなみにコードはvim本体のを参考にしてます |
|
動作確認はUbuntu 16.04でしました。 |
|
あと |
|
vim の src/po/Makefile の check これ、使われてない感じするなぁ… |
* not work on Windows (enc=cp932 env) * friendly error message: print error lines when fail to check * new targets: check, checkclean
|
402ba59 で3点、修正しました。
|
|
Vim 本体へも還元するべきかもしれない。 |
|
@crazymaster とりあえず現状でマージします。ありがとうございました 🙇 |
srcディレクトリのMakefileから叩かれているみたいです。 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: vim-jp/issues#951